]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
usb: isp1760-hcd: Fix fall-through annotations
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Wed, 1 May 2019 15:39:34 +0000 (10:39 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 1 May 2019 16:13:52 +0000 (18:13 +0200)
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.

This patch fixes the following warning:

drivers/usb/isp1760/isp1760-hcd.c: In function ‘collect_qtds’:
drivers/usb/isp1760/isp1760-hcd.c:788:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
      mem_reads8(hcd->regs, qtd->payload_addr,
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        qtd->data_buffer,
        ~~~~~~~~~~~~~~~~~
        qtd->actual_length);
        ~~~~~~~~~~~~~~~~~~~
drivers/usb/isp1760/isp1760-hcd.c:792:5: note: here
     case OUT_PID:
     ^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

Notice that, in this particular case, the code comments are modified
in accordance with what GCC is expecting to find.

This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/isp1760/isp1760-hcd.c

index 8142c6b4c4cfb66de924ee45dcaba6a809b65d13..320fc4739835a19e1a0c4642c7d0f94322f79de3 100644 (file)
@@ -788,11 +788,11 @@ static void collect_qtds(struct usb_hcd *hcd, struct isp1760_qh *qh,
                                        mem_reads8(hcd->regs, qtd->payload_addr,
                                                        qtd->data_buffer,
                                                        qtd->actual_length);
-                                       /* Fall through (?) */
+                                       /* Fall through */
                                case OUT_PID:
                                        qtd->urb->actual_length +=
                                                        qtd->actual_length;
-                                       /* Fall through ... */
+                                       /* Fall through */
                                case SETUP_PID:
                                        break;
                                }