]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
habanalabs: patched cb equals user cb in device memset
authorOded Gabbay <oded.gabbay@gmail.com>
Wed, 22 Jan 2020 22:43:06 +0000 (00:43 +0200)
committerOded Gabbay <oded.gabbay@gmail.com>
Tue, 11 Feb 2020 09:12:47 +0000 (11:12 +0200)
During device memory memset, the driver allocates and use a CB (command
buffer). To reuse existing code, it keeps a pointer to the CB in two
variables, user_cb and patched_cb. Therefore, there is no need to "put"
both the user_cb and patched_cb, as it will cause an underflow of the
refcnt of the CB.

Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>
drivers/misc/habanalabs/goya/goya.c

index f24fe909b88d8505f8c50be99f9b9b9da86f455e..b8a8de24aaf722a3c2f4abee4f4720b616c9761b 100644 (file)
@@ -4690,8 +4690,6 @@ static int goya_memset_device_memory(struct hl_device *hdev, u64 addr, u64 size,
 
        rc = goya_send_job_on_qman0(hdev, job);
 
-       hl_cb_put(job->patched_cb);
-
        hl_debugfs_remove_job(hdev, job);
        kfree(job);
        cb->cs_cnt--;