]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
staging: wlang-ng: avoid new typedef: hfa384x_CommTallies32_t
authorSergio Paracuellos <sergio.paracuellos@gmail.com>
Wed, 28 Sep 2016 18:19:08 +0000 (20:19 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 2 Oct 2016 15:00:48 +0000 (17:00 +0200)
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs

It applies for typedef hfa384x_CommTallies32_t

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wlan-ng/hfa384x.h
drivers/staging/wlan-ng/prism2sta.c

index 1ff46fe3792b82096576bdc5f7f1c7b1189e8c1d..40cbe6407e4951a31f100a02c50edc1da6a2ad96 100644 (file)
@@ -634,7 +634,7 @@ struct hfa384x_CommTallies16 {
        u16 rxmsginbadmsgfrag;
 } __packed;
 
-typedef struct hfa384x_CommTallies32 {
+struct hfa384x_CommTallies32 {
        u32 txunicastframes;
        u32 txmulticastframes;
        u32 txfragments;
@@ -656,7 +656,7 @@ typedef struct hfa384x_CommTallies32 {
        u32 rxdiscardswepundecr;
        u32 rxmsginmsgfrag;
        u32 rxmsginbadmsgfrag;
-} __packed hfa384x_CommTallies32_t;
+} __packed;
 
 /*--  Inquiry Frame, Diagnose: Scan Results & Subfields--*/
 typedef struct hfa384x_ScanResultSub {
@@ -763,7 +763,7 @@ typedef struct hfa384x_KeyIDChanged {
 /*--  Collection of all Inf frames ---------------*/
 typedef union hfa384x_infodata {
        struct hfa384x_CommTallies16 commtallies16;
-       hfa384x_CommTallies32_t commtallies32;
+       struct hfa384x_CommTallies32 commtallies32;
        hfa384x_ScanResult_t scanresult;
        hfa384x_ChInfoResult_t chinforesult;
        hfa384x_HScanResult_t hscanresult;
@@ -1364,7 +1364,7 @@ typedef struct hfa384x {
        struct hfa384x_caplevel cap_act_ap_mfi; /* ap f/w to modem interface */
 
        u32 psusercount;        /* Power save user count. */
-       hfa384x_CommTallies32_t tallies;        /* Communication tallies. */
+       struct hfa384x_CommTallies32 tallies;   /* Communication tallies. */
        u8 comment[WLAN_COMMENT_MAX + 1];       /* User comment */
 
        /* Channel Info request results (AP only) */
index 0b09c05378b50b914c63a301bc15dc9ab09fa371..9b95d6ffffc9d488b35f141c21468ae1d941e6e8 100644 (file)
@@ -999,7 +999,7 @@ static void prism2sta_inf_tallies(struct wlandevice *wlandev,
         * record length of the info record.
         */
 
-       cnt = sizeof(hfa384x_CommTallies32_t) / sizeof(u32);
+       cnt = sizeof(struct hfa384x_CommTallies32) / sizeof(u32);
        if (inf->framelen > 22) {
                dst = (u32 *)&hw->tallies;
                src32 = (u32 *)&inf->info.commtallies32;