gpiolib: use better errno if get_direction is not available

EINVAL is very generic, use ENOTSUPP in case the gpiochip does not
provide this function. While removing the assignment from the 'status'
variable, use better indentation in the declaration block.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 8fbaea52bc1b323daca15dacb74ab53d12e788d7..74f3af2d8ca092aa8ab1c1e584a47f2a562d1550 100644 (file)
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -210,15 +210,15 @@ static int gpiochip_find_base(int ngpio)
  */
 int gpiod_get_direction(struct gpio_desc *desc)
 {
-       struct gpio_chip        *chip;
-       unsigned                offset;
-       int                     status = -EINVAL;
+       struct gpio_chip *chip;
+       unsigned offset;
+       int status;
 
        chip = gpiod_to_chip(desc);
        offset = gpio_chip_hwgpio(desc);
 
        if (!chip->get_direction)
-               return status;
+               return -ENOTSUPP;
 
        status = chip->get_direction(chip, offset);
        if (status > 0) {