]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
qlcnic: Mark expected switch fall-througs
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 7 Aug 2018 23:28:20 +0000 (18:28 -0500)
committerDavid S. Miller <davem@davemloft.net>
Wed, 8 Aug 2018 00:54:20 +0000 (17:54 -0700)
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 1410181 ("Missing break in switch")
Addresses-Coverity-ID: 1410184 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c

index 7f7deeaf1cf07913454a13b4f7801c7b3b07545f..3b0adda7cc9c66769f84a1047a91aaa33c7939c8 100644 (file)
@@ -351,9 +351,9 @@ static int qlcnic_82xx_get_link_ksettings(struct qlcnic_adapter *adapter,
        case QLCNIC_BRDTYPE_P3P_REF_QG:
        case QLCNIC_BRDTYPE_P3P_4_GB:
        case QLCNIC_BRDTYPE_P3P_4_GB_MM:
-
                supported |= SUPPORTED_Autoneg;
                advertising |= ADVERTISED_Autoneg;
+               /* fall through */
        case QLCNIC_BRDTYPE_P3P_10G_CX4:
        case QLCNIC_BRDTYPE_P3P_10G_CX4_LP:
        case QLCNIC_BRDTYPE_P3P_10000_BASE_T:
@@ -377,6 +377,7 @@ static int qlcnic_82xx_get_link_ksettings(struct qlcnic_adapter *adapter,
                supported |= SUPPORTED_TP;
                check_sfp_module = netif_running(adapter->netdev) &&
                                   ahw->has_link_events;
+               /* fall through */
        case QLCNIC_BRDTYPE_P3P_10G_XFP:
                supported |= SUPPORTED_FIBRE;
                advertising |= ADVERTISED_FIBRE;