]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
rtc: ds1672: set range
authorAlexandre Belloni <alexandre.belloni@bootlin.com>
Sun, 7 Apr 2019 21:05:34 +0000 (23:05 +0200)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Mon, 8 Apr 2019 12:35:12 +0000 (14:35 +0200)
The ds1672 is a 32bit seconds counter.

Also remove erroneous comment claiming that epoch is set to 2000, it was
not.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-ds1672.c

index b1ebca099b0dffb064d59c8dfa8821f55374f48c..b9860820cc908dbb597202a759462cdcd1b12a14 100644 (file)
 
 #define DS1672_REG_CONTROL_EOSC        0x80
 
-static struct i2c_driver ds1672_driver;
-
 /*
  * In the routines that deal directly with the ds1672 hardware, we use
  * rtc_time -- month 0-11, hour 0-23, yr = calendar year-epoch
- * Epoch is initialized as 2000. Time is set to UTC.
+ * Time is set to UTC.
  */
 static int ds1672_get_datetime(struct i2c_client *client, struct rtc_time *tm)
 {
@@ -164,8 +162,16 @@ static int ds1672_probe(struct i2c_client *client,
        if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C))
                return -ENODEV;
 
-       rtc = devm_rtc_device_register(&client->dev, ds1672_driver.driver.name,
-                                 &ds1672_rtc_ops, THIS_MODULE);
+       rtc = devm_rtc_allocate_device(&client->dev);
+       if (IS_ERR(rtc))
+               return PTR_ERR(rtc);
+
+       rtc->ops = &ds1672_rtc_ops;
+       rtc->range_max = U32_MAX;
+
+       err = rtc_register_device(rtc);
+       if (err)
+               return err;
 
        if (IS_ERR(rtc))
                return PTR_ERR(rtc);