]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
staging: rtl8723bs: fix comparsion to true/false and brace issues
authorMichael Straube <straube.linux@gmail.com>
Sat, 30 Jun 2018 11:36:27 +0000 (13:36 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 2 Jul 2018 08:43:10 +0000 (10:43 +0200)
Use if(x) and if(!x) instead of comparsion to true/false.
Reported by checkpatch.

Remove unrequired braces from single if else statement.
Add missing space after else: else{ -> else {

Signed-off-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/core/rtw_btcoex.c
drivers/staging/rtl8723bs/core/rtw_efuse.c

index adac915a21530bf5f498405889a8174416c674d7..e56502e301ec6e86b934faa4f5619e952550e1cc 100644 (file)
@@ -77,14 +77,14 @@ void rtw_btcoex_SuspendNotify(struct adapter *padapter, u8 state)
 
 void rtw_btcoex_HaltNotify(struct adapter *padapter)
 {
-       if (false == padapter->bup) {
+       if (!padapter->bup) {
                DBG_871X(FUNC_ADPT_FMT ": bup =%d Skip!\n",
                        FUNC_ADPT_ARG(padapter), padapter->bup);
 
                return;
        }
 
-       if (true == padapter->bSurpriseRemoved) {
+       if (padapter->bSurpriseRemoved) {
                DBG_871X(FUNC_ADPT_FMT ": bSurpriseRemoved =%d Skip!\n",
                        FUNC_ADPT_ARG(padapter), padapter->bSurpriseRemoved);
 
@@ -198,11 +198,11 @@ void rtw_btcoex_RejectApAggregatedPacket(struct adapter *padapter, u8 enable)
        pmlmeinfo = &padapter->mlmeextpriv.mlmext_info;
        psta = rtw_get_stainfo(&padapter->stapriv, get_bssid(&padapter->mlmepriv));
 
-       if (true == enable) {
+       if (enable) {
                pmlmeinfo->accept_addba_req = false;
                if (psta)
                        send_delba(padapter, 0, psta->hwaddr);
-       } else{
+       } else {
                pmlmeinfo->accept_addba_req = true;
        }
 }
index c306ad7e395c9e0df9db7d701cdcf3640dd2bbf4..b3247c9642ea4505463273b372ccf7e03c304e96 100644 (file)
@@ -580,11 +580,10 @@ void EFUSE_ShadowMapUpdate(
 
        EFUSE_GetEfuseDefinition(padapter, efuseType, TYPE_EFUSE_MAP_LEN, (void *)&mapLen, bPseudoTest);
 
-       if (pEEPROM->bautoload_fail_flag == true) {
+       if (pEEPROM->bautoload_fail_flag)
                memset(pEEPROM->efuse_eeprom_data, 0xFF, mapLen);
-       } else{
+       else
                Efuse_ReadAllMap(padapter, efuseType, pEEPROM->efuse_eeprom_data, bPseudoTest);
-       }
 
        /* PlatformMoveMemory((void *)&pHalData->EfuseMap[EFUSE_MODIFY_MAP][0], */
        /* void *)&pHalData->EfuseMap[EFUSE_INIT_MAP][0], mapLen); */