]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
mfd: mxs-lradc: Mark expected switch fall-through
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Mon, 11 Feb 2019 22:48:27 +0000 (16:48 -0600)
committerLee Jones <lee.jones@linaro.org>
Mon, 18 Feb 2019 09:07:22 +0000 (09:07 +0000)
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.

This patch fixes the following warning:

drivers/mfd/mxs-lradc.c: In function ‘mxs_lradc_probe’:
drivers/mfd/mxs-lradc.c:179:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
    if (lradc->soc == IMX28_LRADC) {
       ^
drivers/mfd/mxs-lradc.c:185:3: note: here
   default:
   ^~~~~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

Notice that, in this particular case, the code comment is modified
in accordance with what GCC is expecting to find.

This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/mxs-lradc.c

index 98e732a7ae96f02b3d0b7f825a9bd3e3a3931cbe..a09a8d06302b3e02e7de20bce1023c3a1d5aa8a1 100644 (file)
@@ -181,7 +181,7 @@ static int mxs_lradc_probe(struct platform_device *pdev)
                                        MXS_LRADC_TOUCHSCREEN_5WIRE;
                                break;
                        }
-                       /* fall through to an error message for i.MX23 */
+                       /* fall through to an error message for i.MX23 */
                default:
                        dev_err(&pdev->dev,
                                "Unsupported number of touchscreen wires (%d)\n"