]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
Revert "drm/amdgpu: move PD/PT bos on LRU again"
authorMichel Dänzer <michel.daenzer@amd.com>
Wed, 29 Aug 2018 09:59:38 +0000 (11:59 +0200)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 29 Aug 2018 17:35:43 +0000 (12:35 -0500)
This reverts commit 31625ccae4464b61ec8cdb9740df848bbc857a5b.

It triggered various badness on my development machine when running the
piglit gpu profile with radeonsi on Bonaire, looks like memory
corruption due to insufficiently protected list manipulations.

Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c

index 23c78af850c61a7f5a62830e8824aff18e102239..521ddb358ec17555e4f3f3fe27d951872928105c 100644 (file)
@@ -1127,7 +1127,7 @@ int amdgpu_vm_update_directories(struct amdgpu_device *adev,
                                           struct amdgpu_vm_bo_base,
                                           vm_status);
                bo_base->moved = false;
-               list_move(&bo_base->vm_status, &vm->idle);
+               list_del_init(&bo_base->vm_status);
 
                bo = bo_base->bo->parent;
                if (!bo)