]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
usb: gadget: net2272: remove redundant assignments to pointer 's'
authorColin Ian King <colin.king@canonical.com>
Thu, 30 May 2019 18:14:58 +0000 (19:14 +0100)
committerFelipe Balbi <felipe.balbi@linux.intel.com>
Tue, 18 Jun 2019 08:58:29 +0000 (11:58 +0300)
The pointer 's' is being assigned however the pointer is
never used with either of these values before it it reassigned much
later on.  I suspect it was going to be used in the output of the
main control registers scnprintf but was omitted.  The assignments
of 's' to the driver name or the literal string are redundant and
can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
drivers/usb/gadget/udc/net2272.c

index 564aeee1a1fe728caf1137318aadcd75467a0df6..247de0faaeb7f22df485969648438d8cf601ec7b 100644 (file)
@@ -1178,11 +1178,6 @@ registers_show(struct device *_dev, struct device_attribute *attr, char *buf)
        size = PAGE_SIZE;
        spin_lock_irqsave(&dev->lock, flags);
 
-       if (dev->driver)
-               s = dev->driver->driver.name;
-       else
-               s = "(none)";
-
        /* Main Control Registers */
        t = scnprintf(next, size, "%s version %s,"
                "chiprev %02x, locctl %02x\n"