cfg80211: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/20190703070142.GA29993@kroah.com
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

diff --git a/net/wireless/core.c b/net/wireless/core.c
index 45d9afcff6d5f060c0f60fecd15a7acb42731fc2..742986c73490c99df65ed9b1d4531bf32841cdc3 100644 (file)
--- a/net/wireless/core.c
+++ b/net/wireless/core.c
@@ -142,12 +142,10 @@ int cfg80211_dev_rename(struct cfg80211_registered_device *rdev,
        if (result)
                return result;
 
-       if (rdev->wiphy.debugfsdir &&
-           !debugfs_rename(rdev->wiphy.debugfsdir->d_parent,
-                           rdev->wiphy.debugfsdir,
-                           rdev->wiphy.debugfsdir->d_parent,
-                           newname))
-               pr_err("failed to rename debugfs dir to %s!\n", newname);
+       if (rdev->wiphy.debugfsdir)
+               debugfs_rename(rdev->wiphy.debugfsdir->d_parent,
+                              rdev->wiphy.debugfsdir,
+                              rdev->wiphy.debugfsdir->d_parent, newname);
 
        nl80211_notify_wiphy(rdev, NL80211_CMD_NEW_WIPHY);
 
@@ -899,11 +897,8 @@ int wiphy_register(struct wiphy *wiphy)
        cfg80211_rdev_list_generation++;
 
        /* add to debugfs */
-       rdev->wiphy.debugfsdir =
-               debugfs_create_dir(wiphy_name(&rdev->wiphy),
-                                  ieee80211_debugfs_dir);
-       if (IS_ERR(rdev->wiphy.debugfsdir))
-               rdev->wiphy.debugfsdir = NULL;
+       rdev->wiphy.debugfsdir = debugfs_create_dir(wiphy_name(&rdev->wiphy),
+                                                   ieee80211_debugfs_dir);
 
        cfg80211_debugfs_rdev_add(rdev);
        nl80211_notify_wiphy(rdev, NL80211_CMD_NEW_WIPHY);