EDAC, pnd2: Mask off the lower four bits of a BAR

Bit[0] of BAR is always zero. Bit[2:1] and bit[3] of BAR contain the
information of 'type' and the 'prefetchable' accordingly. Therefore,
mask the lower four bits to retrieve the actual base address of a BAR.

Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
Cc: Tony Luck <tony.luck@intel.com>
Cc: linux-edac <linux-edac@vger.kernel.org>
Link: http://lkml.kernel.org/r/20170814154813.21619-1-qiuxu.zhuo@intel.com
Signed-off-by: Borislav Petkov <bp@suse.de>

diff --git a/drivers/edac/pnd2_edac.c b/drivers/edac/pnd2_edac.c
index a3180a87ff9638d50598f6e806771adffc826bb6..2b16b95201eb025c7c87c1e1e534816bdfce223e 100644 (file)
--- a/drivers/edac/pnd2_edac.c
+++ b/drivers/edac/pnd2_edac.c
@@ -241,6 +241,7 @@ static u64 get_sideband_reg_base_addr(void)
        if (pdev) {
                pci_read_config_dword(pdev, 0x10, &lo);
                pci_read_config_dword(pdev, 0x14, &hi);
+               lo &= 0xfffffff0;
                pci_dev_put(pdev);
                return (U64_LSHIFT(hi, 32) | U64_LSHIFT(lo, 0));
        } else {