]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
mtd: cmdlinepart: allow small partitions
authorBrian Norris <computersforpeace@gmail.com>
Fri, 19 Jun 2015 20:10:06 +0000 (13:10 -0700)
committerBrian Norris <computersforpeace@gmail.com>
Tue, 29 Sep 2015 01:37:31 +0000 (18:37 -0700)
I'm not sure why we have a PAGE_SIZE restriction on this partition
parser.

If we really wanted the restriction, I would expect it to be a
restriction for *all* parsers, so we'd move it to the MTD core

At any rate, while small partitions may not be useful (they'll often be
smaller than the eraseblock size and therefore can only be used
read-only), they still have use as a read-only partition.

This restriction is especially annoying because it aborts the entire
MTD's cmdline parsing, leaving it unpartitioned.

So, let's kill the restriction and only check for zero-sized partitions,
which I expect we don't want to allow.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
drivers/mtd/cmdlinepart.c

index c8503006f17aaf63714cdd98f5e8fe9c80da8c78..477923a8b86fc531f21073e0d3a3d5de682e127d 100644 (file)
@@ -115,9 +115,8 @@ static struct mtd_partition * newpart(char *s,
                s++;
        } else {
                size = memparse(s, &s);
-               if (size < PAGE_SIZE) {
-                       printk(KERN_ERR ERRP "partition size too small (%llx)\n",
-                              size);
+               if (!size) {
+                       printk(KERN_ERR ERRP "partition has size 0\n");
                        return ERR_PTR(-EINVAL);
                }
        }