]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
media: pci: cobalt: Replace GFP_ATOMIC with GFP_KERNEL in cobalt_probe()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Fri, 27 Jul 2018 03:07:04 +0000 (23:07 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Fri, 27 Jul 2018 12:12:15 +0000 (08:12 -0400)
cobalt_probe() is never called in atomic context.
It calls kzalloc() with GFP_ATOMIC, which is not necessary.
GFP_ATOMIC can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/pci/cobalt/cobalt-driver.c

index c8b1a6206c65d585a9f68b01037fb2a1f1c6921d..4885e833c05227999cfcb00266c88917c765472b 100644 (file)
@@ -670,7 +670,7 @@ static int cobalt_probe(struct pci_dev *pci_dev,
        /* FIXME - module parameter arrays constrain max instances */
        i = atomic_inc_return(&cobalt_instance) - 1;
 
-       cobalt = kzalloc(sizeof(struct cobalt), GFP_ATOMIC);
+       cobalt = kzalloc(sizeof(struct cobalt), GFP_KERNEL);
        if (cobalt == NULL)
                return -ENOMEM;
        cobalt->pci_dev = pci_dev;