]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
vsock: add 'struct vsock_sock *' param to vsock_core_get_transport()
authorStefano Garzarella <sgarzare@redhat.com>
Thu, 14 Nov 2019 09:57:41 +0000 (10:57 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 15 Nov 2019 02:12:18 +0000 (18:12 -0800)
Since now the 'struct vsock_sock' object contains a pointer to
the transport, this patch adds a parameter to the
vsock_core_get_transport() to return the right transport
assigned to the socket.

This patch modifies also the virtio_transport_get_ops(), that
uses the vsock_core_get_transport(), adding the
'struct vsock_sock *' parameter.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Jorgen Hansen <jhansen@vmware.com>
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/af_vsock.h
net/vmw_vsock/af_vsock.c
net/vmw_vsock/virtio_transport_common.c

index a5e1e134261dfcda65bff4181aed7ba1b59d3b51..2ca67d048de465b98378360b804e1d6ede2fcad9 100644 (file)
@@ -166,7 +166,7 @@ static inline int vsock_core_init(const struct vsock_transport *t)
 void vsock_core_exit(void);
 
 /* The transport may downcast this to access transport-specific functions */
-const struct vsock_transport *vsock_core_get_transport(void);
+const struct vsock_transport *vsock_core_get_transport(struct vsock_sock *vsk);
 
 /**** UTILS ****/
 
index d813967d7dd593c05b627f67b85d79538fd56ff0..f057acb0ee29f30daf26ce66054ea4a6ac4d0c00 100644 (file)
@@ -1999,12 +1999,9 @@ void vsock_core_exit(void)
 }
 EXPORT_SYMBOL_GPL(vsock_core_exit);
 
-const struct vsock_transport *vsock_core_get_transport(void)
+const struct vsock_transport *vsock_core_get_transport(struct vsock_sock *vsk)
 {
-       /* vsock_register_mutex not taken since only the transport uses this
-        * function and only while registered.
-        */
-       return transport_single;
+       return vsk->transport;
 }
 EXPORT_SYMBOL_GPL(vsock_core_get_transport);
 
index e7b5e99842c9e2d15bcb0cef74bf608fdf4b46b0..b113619d957664a89b9a908d69a957bd05803060 100644 (file)
 /* Threshold for detecting small packets to copy */
 #define GOOD_COPY_LEN  128
 
-static const struct virtio_transport *virtio_transport_get_ops(void)
+static const struct virtio_transport *
+virtio_transport_get_ops(struct vsock_sock *vsk)
 {
-       const struct vsock_transport *t = vsock_core_get_transport();
+       const struct vsock_transport *t = vsock_core_get_transport(vsk);
 
        return container_of(t, struct virtio_transport, transport);
 }
@@ -168,7 +169,7 @@ static int virtio_transport_send_pkt_info(struct vsock_sock *vsk,
        struct virtio_vsock_pkt *pkt;
        u32 pkt_len = info->pkt_len;
 
-       src_cid = virtio_transport_get_ops()->transport.get_local_cid();
+       src_cid = virtio_transport_get_ops(vsk)->transport.get_local_cid();
        src_port = vsk->local_addr.svm_port;
        if (!info->remote_cid) {
                dst_cid = vsk->remote_addr.svm_cid;
@@ -201,7 +202,7 @@ static int virtio_transport_send_pkt_info(struct vsock_sock *vsk,
 
        virtio_transport_inc_tx_pkt(vvs, pkt);
 
-       return virtio_transport_get_ops()->send_pkt(pkt);
+       return virtio_transport_get_ops(vsk)->send_pkt(pkt);
 }
 
 static bool virtio_transport_inc_rx_pkt(struct virtio_vsock_sock *vvs,