qcom: spmi-gpio: Fix boundary conditions IRQ domain translate

GPIOs on the SPMI PMIC are numbered 1..ngpio, so the boundary check in
pmic_gpio_domain_translate() is off by one, correct this.

Fixes: ca69e2d165eb ("qcom: spmi-gpio: add support for hierarchical IRQ chip")
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Brian Masney <masneyb@onstation.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
index e01a556ac586cd1b83fbe1f887063db48fbab394..cb512c7a52513165a390da33b4e9958e16d6f463 100644 (file)
--- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
+++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
@@ -962,7 +962,8 @@ static int pmic_gpio_domain_translate(struct irq_domain *domain,
                                                     struct pmic_gpio_state,
                                                     chip);
 
-       if (fwspec->param_count != 2 || fwspec->param[0] >= state->chip.ngpio)
+       if (fwspec->param_count != 2 ||
+           fwspec->param[0] < 1 || fwspec->param[0] > state->chip.ngpio)
                return -EINVAL;
 
        *hwirq = fwspec->param[0] - PMIC_GPIO_PHYSICAL_OFFSET;