]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
staging: ks7010: refactor function call parameters
authorTobin C. Harding <me@tobin.cc>
Mon, 27 Feb 2017 03:14:48 +0000 (14:14 +1100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 6 Mar 2017 08:17:05 +0000 (09:17 +0100)
Function call parameters are split over more lines than
necessary. Also assignment statements are split after the '=' sign.
This adds extra lines to the function and may also reduces
readability.

Refactor function call parameters and reduce the number of lines
used. Put assignment statements onto single line.

Signed-off-by: Tobin C. Harding <me@tobin.cc>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/ks7010/ks7010_sdio.c

index 04130fb0184218d777fef428d19d199ec48232d2..14580cb4c75573ae9fa9e8805165b2965c617467 100644 (file)
@@ -195,48 +195,34 @@ static int _ks_wlan_hw_power_save(struct ks_wlan_private *priv)
        if (!atomic_read(&priv->psstatus.confirm_wait) &&
                !atomic_read(&priv->psstatus.snooze_guard) &&
                !cnt_txqbody(priv)) {
-               retval =
-                       ks7010_sdio_read(priv, INT_PENDING,
-                                       &rw_data,
-                                       sizeof(rw_data));
+               retval = ks7010_sdio_read(priv, INT_PENDING, &rw_data,
+                                         sizeof(rw_data));
                if (retval) {
-                       DPRINTK(1,
-                               " error : INT_PENDING=%02X\n",
-                               rw_data);
+                       DPRINTK(1, " error : INT_PENDING=%02X\n", rw_data);
                        queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,
-                                       &priv->ks_wlan_hw.rw_wq, 1);
+                                          &priv->ks_wlan_hw.rw_wq, 1);
                        return 0;
                }
                if (!rw_data) {
                        rw_data = GCR_B_DOZE;
-                       retval =
-                               ks7010_sdio_write(priv,
-                                               GCR_B,
-                                               &rw_data,
-                                               sizeof(rw_data));
+                       retval = ks7010_sdio_write(priv, GCR_B, &rw_data,
+                                                  sizeof(rw_data));
                        if (retval) {
-                               DPRINTK(1,
-                                       " error : GCR_B=%02X\n",
-                                       rw_data);
-                               queue_delayed_work
-                                       (priv->ks_wlan_hw.ks7010sdio_wq,
-                                               &priv->ks_wlan_hw.rw_wq, 1);
+                               DPRINTK(1, " error : GCR_B=%02X\n", rw_data);
+                               queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,
+                                                  &priv->ks_wlan_hw.rw_wq, 1);
                                return 0;
                        }
-                       DPRINTK(4,
-                               "PMG SET!! : GCR_B=%02X\n",
-                               rw_data);
+                       DPRINTK(4, "PMG SET!! : GCR_B=%02X\n", rw_data);
                        atomic_set(&priv->psstatus.status, PS_SNOOZE);
-                       DPRINTK(3,
-                               "psstatus.status=PS_SNOOZE\n");
+                       DPRINTK(3, "psstatus.status=PS_SNOOZE\n");
                } else {
                        queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,
-                                       &priv->ks_wlan_hw.rw_wq, 1);
+                                          &priv->ks_wlan_hw.rw_wq, 1);
                }
        } else {
                queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,
-                               &priv->ks_wlan_hw.rw_wq,
-                               0);
+                                  &priv->ks_wlan_hw.rw_wq, 0);
        }
 
        return 0;