]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
dscc4: Undefined signed int shift
authorMichael McConville <mmcco@mykolab.com>
Sat, 6 Feb 2016 01:46:25 +0000 (20:46 -0500)
committerDavid S. Miller <davem@davemloft.net>
Sat, 13 Feb 2016 11:10:21 +0000 (06:10 -0500)
My analysis in the below mail applies, although the second part is
unnecessary because i isn't used in arithmetic operations here:

https://marc.info/?l=openbsd-tech&m=145377854103866&w=2

Thanks for your time.

Signed-off-by: Michael McConville <mmcco@mykolab.com>
Acked-by: Francois Romieu <romieu@fr.zoreil.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wan/dscc4.c

index 7a72407208b161772ba66dc284c7701ea5a85f59..6292259804634e0c6251e23dd8eb7213f16211fb 100644 (file)
@@ -1626,7 +1626,7 @@ static void dscc4_tx_irq(struct dscc4_pci_priv *ppriv,
                if (state & Xpr) {
                        void __iomem *scc_addr;
                        unsigned long ring;
-                       int i;
+                       unsigned int i;
 
                        /*
                         * - the busy condition happens (sometimes);