]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
iommu/vt-d: Fix leak in intel_pasid_alloc_table on error path
authorEric Auger <eric.auger@redhat.com>
Tue, 30 Apr 2019 07:30:04 +0000 (09:30 +0200)
committerJoerg Roedel <jroedel@suse.de>
Fri, 3 May 2019 15:34:27 +0000 (17:34 +0200)
If alloc_pages_node() fails, pasid_table is leaked. Free it.

Fixes: cc580e41260db ("iommu/vt-d: Per PCI device pasid table interfaces")
Signed-off-by: Eric Auger <eric.auger@redhat.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/intel-pasid.c

index 03b12d2ee2132fe624eeed719dc486d89279f2e4..2fefeafda437b91541f09a3c5618754516fc96b6 100644 (file)
@@ -154,8 +154,10 @@ int intel_pasid_alloc_table(struct device *dev)
        order = size ? get_order(size) : 0;
        pages = alloc_pages_node(info->iommu->node,
                                 GFP_KERNEL | __GFP_ZERO, order);
-       if (!pages)
+       if (!pages) {
+               kfree(pasid_table);
                return -ENOMEM;
+       }
 
        pasid_table->table = page_address(pages);
        pasid_table->order = order;