]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
usb: storage: karma: remove useless variable
authorPierre-Yves Kerbrat <pkerbrat@free.fr>
Tue, 28 Feb 2017 21:02:51 +0000 (22:02 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 17 Mar 2017 04:27:41 +0000 (13:27 +0900)
Remove the useless variable 'partial' storing the actual length
transferred. Nothing was done with it, so simply get rid of it
as usb_stor_bulk_transfer_buf can handle having NULL instead.

This also fixes the following sparse issues (-Wtypesign):
drivers/usb/storage/karma.c:122:51: warning: incorrect type in argument
5 (different signedness)
drivers/usb/storage/karma.c:122:51:    expected unsigned int *act_len
drivers/usb/storage/karma.c:122:51:    got int *<noident>
drivers/usb/storage/karma.c:127:52: warning: incorrect type in argument
5 (different signedness)
drivers/usb/storage/karma.c:127:52:    expected unsigned int *act_len
drivers/usb/storage/karma.c:127:52:    got int *<noident>

Signed-off-by: Pierre-Yves Kerbrat <pkerbrat@free.fr>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/storage/karma.c

index f9d407f0b50868d2c576f2e57ddae64de0a26aad..b05ba4929f00e7f9487306e7ecebce87b86b295e 100644 (file)
@@ -105,7 +105,7 @@ static struct us_unusual_dev karma_unusual_dev_list[] = {
  */
 static int rio_karma_send_command(char cmd, struct us_data *us)
 {
-       int result, partial;
+       int result;
        unsigned long timeout;
        static unsigned char seq = 1;
        struct karma_data *data = (struct karma_data *) us->extra;
@@ -119,12 +119,12 @@ static int rio_karma_send_command(char cmd, struct us_data *us)
        timeout = jiffies + msecs_to_jiffies(6000);
        for (;;) {
                result = usb_stor_bulk_transfer_buf(us, us->send_bulk_pipe,
-                       us->iobuf, RIO_SEND_LEN, &partial);
+                       us->iobuf, RIO_SEND_LEN, NULL);
                if (result != USB_STOR_XFER_GOOD)
                        goto err;
 
                result = usb_stor_bulk_transfer_buf(us, us->recv_bulk_pipe,
-                       data->recv, RIO_RECV_LEN, &partial);
+                       data->recv, RIO_RECV_LEN, NULL);
                if (result != USB_STOR_XFER_GOOD)
                        goto err;