]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
Revert "serial: core: Use cons->index for preferred console registration"
authorMichal Simek <michal.simek@xilinx.com>
Wed, 16 Oct 2019 10:36:41 +0000 (12:36 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 16 Oct 2019 11:05:24 +0000 (04:05 -0700)
This reverts commit 91daae03188e0dd1da3c1b599df4ce7539d5a69f.

The origin patch is causing an issue on r8a7791/koelsch and
r8a7795/salvator-xs platforms where cons->index is not initialized to
expected value.
It is safer to revert this patch for now till it is clear why this is
happening.

Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Link: https://lore.kernel.org/r/59f51af6bb03fce823663764d17ad0291aa01ab2.1571222199.git.michal.simek@xilinx.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/serial_core.c

index b64ae2ca8bf2b5d4353590604fa42f311819ce92..c4a414a46c7fef07ccafcbbfeb0adbec1ba1f7e3 100644 (file)
@@ -2832,8 +2832,7 @@ int uart_add_one_port(struct uart_driver *drv, struct uart_port *uport)
                lockdep_set_class(&uport->lock, &port_lock_key);
        }
        if (uport->cons && uport->dev)
-               of_console_check(uport->dev->of_node, uport->cons->name,
-                                uport->cons->index);
+               of_console_check(uport->dev->of_node, uport->cons->name, uport->line);
 
        uart_configure_port(drv, state, uport);