]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
video: smscufx: Improve a size determination in two functions
authorMarkus Elfring <elfring@users.sourceforge.net>
Fri, 29 Dec 2017 18:48:44 +0000 (19:48 +0100)
committerBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Fri, 29 Dec 2017 18:48:44 +0000 (19:48 +0100)
Replace the specification of data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Cc: Steve Glendinning <steve.glendinning@shawell.net>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
drivers/video/fbdev/smscufx.c

index 2275e80b577669afcede4323616a273a47e3ed73..8db7085e5d1aa345df4a842f7698c3800d3918ab 100644 (file)
@@ -1086,8 +1086,7 @@ static int ufx_ops_open(struct fb_info *info, int user)
 
                struct fb_deferred_io *fbdefio;
 
-               fbdefio = kzalloc(sizeof(struct fb_deferred_io), GFP_KERNEL);
-
+               fbdefio = kzalloc(sizeof(*fbdefio), GFP_KERNEL);
                if (fbdefio) {
                        fbdefio->delay = UFX_DEFIO_WRITE_DELAY;
                        fbdefio->deferred_io = ufx_dpy_deferred_io;
@@ -1875,7 +1874,7 @@ static int ufx_alloc_urb_list(struct ufx_data *dev, int count, size_t size)
        INIT_LIST_HEAD(&dev->urbs.list);
 
        while (i < count) {
-               unode = kzalloc(sizeof(struct urb_node), GFP_KERNEL);
+               unode = kzalloc(sizeof(*unode), GFP_KERNEL);
                if (!unode)
                        break;
                unode->dev = dev;