]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
udlfb: Make dlfb_ops constant
authorNishka Dasgupta <nishkadg.linux@gmail.com>
Mon, 19 Aug 2019 07:52:36 +0000 (13:22 +0530)
committerBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Mon, 19 Aug 2019 13:52:29 +0000 (15:52 +0200)
Static structure dlfb_ops, of type fb_ops, is not used except to be
copied into another variable. Hence make dlfb_ops constant to protect it
from unintended modification.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Cc: Bernie Thompson <bernie@plugable.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190819075236.1051-1-nishkadg.linux@gmail.com
drivers/video/fbdev/udlfb.c

index c328e8265cb11e4ed5ecb4fdec829ffeff1df71f..fe373b63ddd6d0422c2aeab8106d0efa47f623af 100644 (file)
@@ -1183,7 +1183,7 @@ static int dlfb_ops_blank(int blank_mode, struct fb_info *info)
        return 0;
 }
 
-static struct fb_ops dlfb_ops = {
+static const struct fb_ops dlfb_ops = {
        .owner = THIS_MODULE,
        .fb_read = fb_sys_read,
        .fb_write = dlfb_ops_write,