]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
ice: use pkg_dwnld_status instead of sq_last_status
authorBruce Allan <bruce.w.allan@intel.com>
Wed, 6 Nov 2019 10:05:35 +0000 (02:05 -0800)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Fri, 8 Nov 2019 20:02:59 +0000 (12:02 -0800)
Since the return value from the Download Package AQ command is stored in
hw->pkg_dwnld_status, use that instead of sq_last_status since that may
have the return value from some other AQ command leading to unexpected
results.

Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/ice/ice_main.c

index cb93fe5529f6894b07d567f2ab1d96c4ec473324..4f4ebb4995591fbba5a057b558ce7362dcb38ea4 100644 (file)
@@ -2900,7 +2900,7 @@ ice_log_pkg_init(struct ice_hw *hw, enum ice_status *status)
                                ICE_PKG_SUPP_VER_MAJ, ICE_PKG_SUPP_VER_MNR);
                break;
        case ICE_ERR_AQ_ERROR:
-               switch (hw->adminq.sq_last_status) {
+               switch (hw->pkg_dwnld_status) {
                case ICE_AQ_RC_ENOSEC:
                case ICE_AQ_RC_EBADSIG:
                        dev_err(dev,