]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
firmware: google: memconsole: Drop __iomem on memremap memory
authorStephen Boyd <swboyd@chromium.org>
Fri, 10 May 2019 18:01:49 +0000 (11:01 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 24 May 2019 18:55:04 +0000 (20:55 +0200)
memremap() doesn't return __iomem marked memory, so drop the marking
here. This makes static analysis tools like sparse happy again.

Cc: Wei-Ning Huang <wnhuang@chromium.org>
Cc: Julius Werner <jwerner@chromium.org>
Cc: Brian Norris <briannorris@chromium.org>
Cc: Samuel Holland <samuel@sholland.org>
Cc: Guenter Roeck <groeck@chromium.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Julius Werner <jwerner@chromium.org>
Reviewed-by: Samuel Holland <samuel@sholland.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/firmware/google/memconsole-coreboot.c

index cc3797f1ba85e3db5c5785204f469d941204887d..6f695b9af3c9dcf5b28865ac14079f16f3566650 100644 (file)
@@ -34,7 +34,7 @@ struct cbmem_cons {
 #define CURSOR_MASK ((1 << 28) - 1)
 #define OVERFLOW (1 << 31)
 
-static struct cbmem_cons __iomem *cbmem_console;
+static struct cbmem_cons *cbmem_console;
 static u32 cbmem_console_size;
 
 /*
@@ -75,7 +75,7 @@ static ssize_t memconsole_coreboot_read(char *buf, loff_t pos, size_t count)
 
 static int memconsole_probe(struct coreboot_device *dev)
 {
-       struct cbmem_cons __iomem *tmp_cbmc;
+       struct cbmem_cons *tmp_cbmc;
 
        tmp_cbmc = memremap(dev->cbmem_ref.cbmem_addr,
                            sizeof(*tmp_cbmc), MEMREMAP_WB);