bnxt_en: Check for zero length value in bnxt_get_nvram_item().

Return -EINVAL if the length is zero and not proceed to do essentially
nothing.

Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
index 3cbe771b335296ce526122e892349e741ddb43b9..85be1cb41f1a854e3ecb38e57d29d5729389d73d 100644 (file)
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
@@ -1773,6 +1773,9 @@ static int bnxt_get_nvram_item(struct net_device *dev, u32 index, u32 offset,
        dma_addr_t dma_handle;
        struct hwrm_nvm_read_input req = {0};
 
+       if (!length)
+               return -EINVAL;
+
        buf = dma_alloc_coherent(&bp->pdev->dev, length, &dma_handle,
                                 GFP_KERNEL);
        if (!buf) {