]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
pinctrl: mcp23s08: Do not complain about unsupported params
authorJan Kundrát <jan.kundrat@cesnet.cz>
Thu, 7 Mar 2019 13:16:51 +0000 (14:16 +0100)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 7 May 2019 09:47:14 +0000 (11:47 +0200)
It is expected that some of these operations won't work on each and
every HW. Previously, even a simple `cat
/sys/kernel/debug/pinctrl/spi1.1/pinconf-pins` caused excessive dmesg
output.

Signed-off-by: Jan Kundrát <jan.kundrat@cesnet.cz>
Cc: Phil Reid <preid@electromag.com.au>
Cc: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Cc: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-mcp23s08.c

index 5d7a8514def91927466bf5b6ff63ccbe2a16692d..fd9d6f026d7000c89bdc6234a2d13e953cd1f55b 100644 (file)
@@ -266,7 +266,6 @@ static int mcp_pinconf_get(struct pinctrl_dev *pctldev, unsigned int pin,
                status = (data & BIT(pin)) ? 1 : 0;
                break;
        default:
-               dev_err(mcp->dev, "Invalid config param %04x\n", param);
                return -ENOTSUPP;
        }
 
@@ -293,7 +292,7 @@ static int mcp_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
                        ret = mcp_set_bit(mcp, MCP_GPPU, pin, arg);
                        break;
                default:
-                       dev_err(mcp->dev, "Invalid config param %04x\n", param);
+                       dev_dbg(mcp->dev, "Invalid config param %04x\n", param);
                        return -ENOTSUPP;
                }
        }