]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
media: vimc: fix start stream when link is disabled
authorHelen Fornazier <helen.koike@collabora.com>
Fri, 7 Dec 2018 17:56:41 +0000 (12:56 -0500)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Fri, 7 Dec 2018 18:08:41 +0000 (13:08 -0500)
If link is disabled, media_entity_remote_pad returns NULL, causing a
NULL pointer deference.
Ignore links that are not enabled instead.

Signed-off-by: Helen Koike <helen.koike@collabora.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/platform/vimc/vimc-common.c

index dee1b9dfc4f64ba3a274c8775ad9531a3fa332b4..867e24dbd6b585161f5bfad949f159218bbec879 100644 (file)
@@ -276,6 +276,8 @@ int vimc_pipeline_s_stream(struct media_entity *ent, int enable)
 
                /* Start the stream in the subdevice direct connected */
                pad = media_entity_remote_pad(&ent->pads[i]);
+               if (!pad)
+                       continue;
 
                if (!is_media_entity_v4l2_subdev(pad->entity))
                        return -EINVAL;