]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
USB: core: fix device node leak
authorJohan Hovold <johan@kernel.org>
Tue, 6 Jun 2017 15:58:58 +0000 (17:58 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 13 Jun 2017 09:07:32 +0000 (11:07 +0200)
Make sure to release any OF device-node reference taken when creating
the USB device.

Note that we currently do not hold a reference to the root hub
device-tree node (i.e. the parent controller node).

Fixes: 69bec7259853 ("USB: core: let USB device know device node")
Cc: stable <stable@vger.kernel.org> # v4.6
Acked-by: Peter Chen <peter.chen@nxp.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/core/usb.c

index 28b053cacc90556acf7df562fdc502c51b25a02e..62e1906bb2f31d2e76afc0661c942711fcf44765 100644 (file)
@@ -416,6 +416,8 @@ static void usb_release_dev(struct device *dev)
 
        usb_destroy_configuration(udev);
        usb_release_bos_descriptor(udev);
+       if (udev->parent)
+               of_node_put(dev->of_node);
        usb_put_hcd(hcd);
        kfree(udev->product);
        kfree(udev->manufacturer);