]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
perf unwind: Remove unnecessary test
authorJohn Keeping <john@metanate.com>
Thu, 15 Aug 2019 10:01:46 +0000 (11:01 +0100)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 16 Aug 2019 15:30:14 +0000 (12:30 -0300)
If dwarf_callchain_users is false, then unwind__prepare_access() will
not set unwind_libunwind_ops so the remaining test here is sufficient.

Signed-off-by: John Keeping <john@metanate.com>
Reviewed-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: john keeping <john@metanate.com>
Link: http://lkml.kernel.org/r/20190815100146.28842-3-john@metanate.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/unwind-libunwind.c

index b843f9d0a9ea2353908768e51c804f3c2a69473d..6499b22b158bd2769b7ef1f2b7b977e4385eac03 100644 (file)
@@ -69,18 +69,12 @@ int unwind__prepare_access(struct map_groups *mg, struct map *map,
 
 void unwind__flush_access(struct map_groups *mg)
 {
-       if (!dwarf_callchain_users)
-               return;
-
        if (mg->unwind_libunwind_ops)
                mg->unwind_libunwind_ops->flush_access(mg);
 }
 
 void unwind__finish_access(struct map_groups *mg)
 {
-       if (!dwarf_callchain_users)
-               return;
-
        if (mg->unwind_libunwind_ops)
                mg->unwind_libunwind_ops->finish_access(mg);
 }