]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
spi: pxa2xx: Disable runtime PM if controller registration fails
authorJarkko Nikula <jarkko.nikula@linux.intel.com>
Wed, 7 Mar 2018 15:05:04 +0000 (17:05 +0200)
committerMark Brown <broonie@kernel.org>
Wed, 7 Mar 2018 15:08:04 +0000 (15:08 +0000)
Don't leave runtime PM enabled in case devm_spi_register_controller()
returns with an error. Otherwise runtime PM will complain when driver is
reloaded:

[  693.855811] pxa2xx-spi pxa2xx-spi.13: Unbalanced pm_runtime_enable!

Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-pxa2xx.c

index b0822d1dba298fced70045495f48f33d49db8ca3..56254b35875d532aaaaf39447c94386849f3ef99 100644 (file)
@@ -1802,6 +1802,8 @@ static int pxa2xx_spi_probe(struct platform_device *pdev)
        return status;
 
 out_error_clock_enabled:
+       pm_runtime_put_noidle(&pdev->dev);
+       pm_runtime_disable(&pdev->dev);
        clk_disable_unprepare(ssp->clk);
        pxa2xx_spi_dma_release(drv_data);
        free_irq(ssp->irq, drv_data);