]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
arm64: fix for bad_mode() handler to always result in panic
authorHari Vyas <hari.vyas@broadcom.com>
Tue, 7 Aug 2018 11:03:48 +0000 (16:33 +0530)
committerCatalin Marinas <catalin.marinas@arm.com>
Fri, 14 Sep 2018 16:46:25 +0000 (17:46 +0100)
The bad_mode() handler is called if we encounter an uunknown exception,
with the expectation that the subsequent call to panic() will halt the
system. Unfortunately, if the exception calling bad_mode() is taken from
EL0, then the call to die() can end up killing the current user task and
calling schedule() instead of falling through to panic().

Remove the die() call altogether, since we really want to bring down the
machine in this "impossible" case.

Signed-off-by: Hari Vyas <hari.vyas@broadcom.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
arch/arm64/kernel/traps.c

index 539b470f952623e9fdbce5b2d5c79ecacc98eeae..ce29973b9bfe90042aceb1064c31958541f981cb 100644 (file)
@@ -606,7 +606,6 @@ asmlinkage void bad_mode(struct pt_regs *regs, int reason, unsigned int esr)
                handler[reason], smp_processor_id(), esr,
                esr_get_class_string(esr));
 
-       die("Oops - bad mode", regs, 0);
        local_daif_mask();
        panic("bad mode");
 }