]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
drm/i915: Drop redundant aspec ratio prop value initialization
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Thu, 20 Jun 2019 14:26:39 +0000 (17:26 +0300)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Thu, 14 Nov 2019 17:49:19 +0000 (19:49 +0200)
HDMI_PICTURE_ASPECT_NONE is zero and the connector state is kzalloc()'d
so no need to initialize conn_state->picture_aspect_ratio with it.

Cc: Ilia Mirkin <imirkin@alum.mit.edu>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190620142639.17518-6-ville.syrjala@linux.intel.com
Reviewed-by: Uma Shankar <uma.shankar@intel.com>
drivers/gpu/drm/i915/display/intel_hdmi.c
drivers/gpu/drm/i915/display/intel_sdvo.c

index 315920c35cc04255813c20da12ee3da15c4a790e..29a174af5314d758a3c1a0bca1865e34afbf34a7 100644 (file)
@@ -2876,7 +2876,6 @@ intel_hdmi_add_properties(struct intel_hdmi *intel_hdmi, struct drm_connector *c
                intel_attach_colorspace_property(connector);
 
        drm_connector_attach_content_type_property(connector);
-       connector->state->picture_aspect_ratio = HDMI_PICTURE_ASPECT_NONE;
 
        if (INTEL_GEN(dev_priv) >= 10 || IS_GEMINILAKE(dev_priv))
                drm_object_attach_property(&connector->base,
index c9cae6a9e8974355232aac91457ff4bb0f98c3cc..8758ee2a444282ad85b6070dd834e5ea2418edb5 100644 (file)
@@ -2654,7 +2654,6 @@ intel_sdvo_add_hdmi_properties(struct intel_sdvo *intel_sdvo,
                intel_attach_broadcast_rgb_property(&connector->base.base);
        }
        intel_attach_aspect_ratio_property(&connector->base.base);
-       connector->base.base.state->picture_aspect_ratio = HDMI_PICTURE_ASPECT_NONE;
 }
 
 static struct intel_sdvo_connector *intel_sdvo_connector_alloc(void)