]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
spi-nor: intel-spi: Remove useless 'buf' parameter in the HW/SW cycle
authorBin Meng <bmeng.cn@gmail.com>
Mon, 11 Sep 2017 09:41:52 +0000 (02:41 -0700)
committerCyrille Pitchen <cyrille.pitchen@wedev4u.fr>
Wed, 11 Oct 2017 07:40:54 +0000 (09:40 +0200)
intel_spi_hw_cycle() and intel_spi_sw_cycle() don't use the parameter
'buf' at all. Remove it.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
drivers/mtd/spi-nor/intel-spi.c

index e5b52e8b08eff20cb72e7864eab7654c22546c30..07626caa7b324576dd68af9e7489ea22521ab7c8 100644 (file)
@@ -377,8 +377,7 @@ static int intel_spi_opcode_index(struct intel_spi *ispi, u8 opcode)
        return -EINVAL;
 }
 
-static int intel_spi_hw_cycle(struct intel_spi *ispi, u8 opcode, u8 *buf,
-                             int len)
+static int intel_spi_hw_cycle(struct intel_spi *ispi, u8 opcode, int len)
 {
        u32 val, status;
        int ret;
@@ -418,8 +417,7 @@ static int intel_spi_hw_cycle(struct intel_spi *ispi, u8 opcode, u8 *buf,
        return 0;
 }
 
-static int intel_spi_sw_cycle(struct intel_spi *ispi, u8 opcode, u8 *buf,
-                             int len)
+static int intel_spi_sw_cycle(struct intel_spi *ispi, u8 opcode, int len)
 {
        u32 val, status;
        int ret;
@@ -456,9 +454,9 @@ static int intel_spi_read_reg(struct spi_nor *nor, u8 opcode, u8 *buf, int len)
        writel(0, ispi->base + FADDR);
 
        if (ispi->swseq)
-               ret = intel_spi_sw_cycle(ispi, opcode, buf, len);
+               ret = intel_spi_sw_cycle(ispi, opcode, len);
        else
-               ret = intel_spi_hw_cycle(ispi, opcode, buf, len);
+               ret = intel_spi_hw_cycle(ispi, opcode, len);
 
        if (ret)
                return ret;
@@ -486,8 +484,8 @@ static int intel_spi_write_reg(struct spi_nor *nor, u8 opcode, u8 *buf, int len)
                return ret;
 
        if (ispi->swseq)
-               return intel_spi_sw_cycle(ispi, opcode, buf, len);
-       return intel_spi_hw_cycle(ispi, opcode, buf, len);
+               return intel_spi_sw_cycle(ispi, opcode, len);
+       return intel_spi_hw_cycle(ispi, opcode, len);
 }
 
 static ssize_t intel_spi_read(struct spi_nor *nor, loff_t from, size_t len,