]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
ath10k: sdio: jump to correct label in error handling path
authorNiklas Cassel <niklas.cassel@linaro.org>
Thu, 26 Apr 2018 12:35:02 +0000 (14:35 +0200)
committerKalle Valo <kvalo@codeaurora.org>
Fri, 27 Apr 2018 11:39:32 +0000 (14:39 +0300)
Jump to the correct label in error handling path.
At this point of execution create_singlethread_workqueue() has succeeded,
so it should be properly destroyed.

Jump label was renamed in commit ec2c64e20257 ("ath10k: sdio: fix memory
leak for probe allocations").
However, the bug was originally introduced in commit d96db25d2025
("ath10k: add initial SDIO support").

Fixes: d96db25d2025 ("ath10k: add initial SDIO support")
Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/ath/ath10k/sdio.c

index 2d04c54a41538f44bdfd3d34593dab22570d21cf..d612ce8c9cffeefb927218977daebdaada99435c 100644 (file)
@@ -2011,7 +2011,7 @@ static int ath10k_sdio_probe(struct sdio_func *func,
                ret = -ENODEV;
                ath10k_err(ar, "unsupported device id %u (0x%x)\n",
                           dev_id_base, id->device);
-               goto err_core_destroy;
+               goto err_free_wq;
        }
 
        ar->id.vendor = id->vendor;