]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
platform/x86: intel_pmc_ipc: fix gcr offset
authorKuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Sun, 9 Apr 2017 22:00:16 +0000 (15:00 -0700)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 28 Apr 2017 18:51:26 +0000 (21:51 +0300)
According to Broxton APL spec, PMC MIMO resources for Global Control
Registers(GCR) are located at 4K(0x1000) offset from IPC base address.
In this driver, PLAT_RESOURCE_GCR_OFFSET macro defines the offset of GCR
region base address from IPC base address and its current value of
0x1008 is incorrect because it points to location for PMC_CFG register
and not the GCR base address itself.

GCR Base = IPC1 Base + 0x1000.

This patch fixes this offset issue.

Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/platform/x86/intel_pmc_ipc.c

index 0651d47b8eeb7e59aa371ff61388a1df79b25ce0..0a3359240227432857215e9f5e18b0fc89bf31ea 100644 (file)
@@ -82,7 +82,7 @@
 /* exported resources from IFWI */
 #define PLAT_RESOURCE_IPC_INDEX                0
 #define PLAT_RESOURCE_IPC_SIZE         0x1000
-#define PLAT_RESOURCE_GCR_OFFSET       0x1008
+#define PLAT_RESOURCE_GCR_OFFSET       0x1000
 #define PLAT_RESOURCE_GCR_SIZE         0x1000
 #define PLAT_RESOURCE_BIOS_DATA_INDEX  1
 #define PLAT_RESOURCE_BIOS_IFACE_INDEX 2