]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
ALSA: pcm: Correct broken procfs set up
authorTakashi Iwai <tiwai@suse.de>
Thu, 24 Aug 2017 20:11:07 +0000 (22:11 +0200)
committerTakashi Iwai <tiwai@suse.de>
Thu, 24 Aug 2017 22:05:16 +0000 (00:05 +0200)
The commit c8da9be4a75f ("ALSA: pcm: Adjust nine function calls
together with a variable assignment") contained a badly incorrect
conversion, a "status" PCM procfs creation was replaced with the next
one.  Luckily, this could be spotted easily by the kernel runtime
warning.

Fixes: c8da9be4a75f ("ALSA: pcm: Adjust nine function calls together...")
Reported-by: Fabio Estevam <fabio.estevam@nxp.com>
Tested-by: Fabio Estevam <fabio.estevam@nxp.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/pcm.c

index c790f79e45aec7d5952dd314d15e1a570cd84dcc..7eadb7fd807471666bfd6907934bcb2e5b0b6f6b 100644 (file)
@@ -625,7 +625,8 @@ static int snd_pcm_substream_proc_init(struct snd_pcm_substream *substream)
                }
        }
        substream->proc_sw_params_entry = entry;
-       entry = snd_info_create_module_entry(THIS_MODULE, "pcm", NULL);
+       entry = snd_info_create_card_entry(card, "status",
+                                          substream->proc_root);
        if (entry) {
                snd_info_set_text_ops(entry, substream,
                                      snd_pcm_substream_proc_status_read);