]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
media: mn88472: don't check retval after our own assignemt
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Thu, 13 Jun 2019 15:54:18 +0000 (12:54 -0300)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Tue, 13 Aug 2019 14:48:04 +0000 (11:48 -0300)
No need to check a retval after we assigned a constant to it.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/dvb-frontends/mn88472.c

index ef8094aa97df84c628b8c29c63763f504b68e9fc..73922fc8f39c22bc4c27ab4ae1b9cf4c065db626 100644 (file)
@@ -616,8 +616,7 @@ static int mn88472_probe(struct i2c_client *client,
        if (IS_ERR(dev->client[1])) {
                ret = PTR_ERR(dev->client[1]);
                dev_err(&client->dev, "I2C registration failed\n");
-               if (ret)
-                       goto err_regmap_0_regmap_exit;
+               goto err_regmap_0_regmap_exit;
        }
        dev->regmap[1] = regmap_init_i2c(dev->client[1], &regmap_config);
        if (IS_ERR(dev->regmap[1])) {
@@ -630,8 +629,7 @@ static int mn88472_probe(struct i2c_client *client,
        if (IS_ERR(dev->client[2])) {
                ret = PTR_ERR(dev->client[2]);
                dev_err(&client->dev, "2nd I2C registration failed\n");
-               if (ret)
-                       goto err_regmap_1_regmap_exit;
+               goto err_regmap_1_regmap_exit;
        }
        dev->regmap[2] = regmap_init_i2c(dev->client[2], &regmap_config);
        if (IS_ERR(dev->regmap[2])) {