]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
cxgb4: Fix error handling path in 'init_one()'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Tue, 6 Feb 2018 20:17:17 +0000 (21:17 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 8 Feb 2018 02:46:06 +0000 (21:46 -0500)
Commit baf5086840ab1 ("cxgb4: restructure VF mgmt code") has reordered
some code but an error handling label has not been updated accordingly.
So fix it and free 'adapter' if 't4_wait_dev_ready()' fails.

Fixes: baf5086840ab1 ("cxgb4: restructure VF mgmt code")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c

index 1ca2a39ed0f856437abbdccbf3fd262e133975a2..56bc626ef00688a5a03f4ccdd349e3acd44555b7 100644 (file)
@@ -5166,7 +5166,7 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
        adapter->regs = regs;
        err = t4_wait_dev_ready(regs);
        if (err < 0)
-               goto out_unmap_bar0;
+               goto out_free_adapter;
 
        /* We control everything through one PF */
        whoami = readl(regs + PL_WHOAMI_A);