]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
net: sis: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles
authorYang Wei <yang.wei9@zte.com.cn>
Tue, 12 Feb 2019 15:59:04 +0000 (23:59 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 14 Feb 2019 04:50:42 +0000 (20:50 -0800)
dev_consume_skb_irq() should be called when skb xmit done. It makes
drop profiles(dropwatch, perf) more friendly.

Signed-off-by: Yang Wei <yang.wei9@zte.com.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/sis/sis190.c
drivers/net/ethernet/sis/sis900.c

index 808cf98166737fdf2e8db974263f12cd9394afe3..5b351beb78cbea9ed185259c317b2744aeaf5c90 100644 (file)
@@ -714,7 +714,7 @@ static void sis190_tx_interrupt(struct net_device *dev,
 
                sis190_unmap_tx_skb(tp->pci_dev, skb, txd);
                tp->Tx_skbuff[entry] = NULL;
-               dev_kfree_skb_irq(skb);
+               dev_consume_skb_irq(skb);
        }
 
        if (tp->dirty_tx != dirty_tx) {
index 4bb89f74742c908386410c23640ddbe6462c9cfc..6073387511f887e4b0cf069041a0b04b759572d1 100644 (file)
@@ -1927,7 +1927,7 @@ static void sis900_finish_xmit (struct net_device *net_dev)
                pci_unmap_single(sis_priv->pci_dev,
                        sis_priv->tx_ring[entry].bufptr, skb->len,
                        PCI_DMA_TODEVICE);
-               dev_kfree_skb_irq(skb);
+               dev_consume_skb_irq(skb);
                sis_priv->tx_skbuff[entry] = NULL;
                sis_priv->tx_ring[entry].bufptr = 0;
                sis_priv->tx_ring[entry].cmdsts = 0;