]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
ARM: tegra: Correct interrupt type for ARM TWD
authorJon Hunter <jonathanh@nvidia.com>
Thu, 17 Mar 2016 14:19:05 +0000 (14:19 +0000)
committerThierry Reding <treding@nvidia.com>
Tue, 12 Apr 2016 15:10:26 +0000 (17:10 +0200)
The ARM TWD interrupt is a private peripheral interrupt (PPI) and per
the ARM GIC documentation, whether the type for PPIs can be set is
IMPLEMENTATION DEFINED. For Tegra20/30 devices the PPI type cannot be
set and so when we attempt to set the type for the ARM TWD interrupt it
fails. This has gone unnoticed because it fails silently and because we
cannot re-configure the type it has had no impact. Nevertheless fix the
type for the TWD interrupt so that it matches the hardware configuration.

Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
arch/arm/boot/dts/tegra20.dtsi
arch/arm/boot/dts/tegra30.dtsi

index 8fb61b93c226a255a3ddae7c7c767b54c425f34e..2207c08e3fa33b9015b0ef8c8275b99d26f834b5 100644 (file)
@@ -145,7 +145,7 @@ timer@50040600 {
                interrupt-parent = <&intc>;
                reg = <0x50040600 0x20>;
                interrupts = <GIC_PPI 13
-                       (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_HIGH)>;
+                       (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_EDGE_RISING)>;
                clocks = <&tegra_car TEGRA20_CLK_TWD>;
        };
 
index c6edc8cea34ed79f77c377e819733d783b409191..5030065cbdfe38df667fb8cc9e89e4154d5a7798 100644 (file)
@@ -230,7 +230,7 @@ timer@50040600 {
                reg = <0x50040600 0x20>;
                interrupt-parent = <&intc>;
                interrupts = <GIC_PPI 13
-                       (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
+                       (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_EDGE_RISING)>;
                clocks = <&tegra_car TEGRA30_CLK_TWD>;
        };