]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
mtd: nand: qcom: remove redundant chip select compatible string
authorAbhishek Sahu <absahu@codeaurora.org>
Wed, 19 Jul 2017 11:47:53 +0000 (17:17 +0530)
committerBoris Brezillon <boris.brezillon@free-electrons.com>
Wed, 23 Aug 2017 14:49:15 +0000 (16:49 +0200)
Currently the compatible “qcom,nandcs” is being used for each
connected NAND device to support for multiple NAND devices in the
same bus. The same thing can be achieved by looking reg property
for each sub nodes which contains the chip select number so this
patch removes the use of “qcom,nandcs” for specifying NAND device
sub nodes.

Since there is no user for this driver currently in so
changing compatible string is safe.

Signed-off-by: Abhishek Sahu <absahu@codeaurora.org>
Reviewed-by: Archit Taneja <architt@codeaurora.org>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
drivers/mtd/nand/qcom_nandc.c

index 9c4c1ccb5d0f1e6f0e7efc618cb8297106df66d5..ec5ec2c4b688ea523abfc108e3fbba3ea2acee7c 100644 (file)
@@ -2127,22 +2127,20 @@ static int qcom_nandc_probe(struct platform_device *pdev)
                goto err_setup;
 
        for_each_available_child_of_node(dn, child) {
-               if (of_device_is_compatible(child, "qcom,nandcs")) {
-                       host = devm_kzalloc(dev, sizeof(*host), GFP_KERNEL);
-                       if (!host) {
-                               of_node_put(child);
-                               ret = -ENOMEM;
-                               goto err_cs_init;
-                       }
-
-                       ret = qcom_nand_host_init(nandc, host, child);
-                       if (ret) {
-                               devm_kfree(dev, host);
-                               continue;
-                       }
+               host = devm_kzalloc(dev, sizeof(*host), GFP_KERNEL);
+               if (!host) {
+                       of_node_put(child);
+                       ret = -ENOMEM;
+                       goto err_cs_init;
+               }
 
-                       list_add_tail(&host->node, &nandc->host_list);
+               ret = qcom_nand_host_init(nandc, host, child);
+               if (ret) {
+                       devm_kfree(dev, host);
+                       continue;
                }
+
+               list_add_tail(&host->node, &nandc->host_list);
        }
 
        if (list_empty(&nandc->host_list)) {