drm/dsi: clean up DSI data type definitions

Rename picture parameter set (it's a long packet, not a long write) and
compression mode (it's not a DCS command) enumerations according to the
DSI specification. Order the types according to the spec. Use tabs
instead of spaces for indentation. Use all lower case for hex.

Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
Reviewed-by: Vandita Kulkarni <vandita.kulkarni@intel.com>
Reviewed-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191028150047.22048-1-jani.nikula@intel.com

diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c
index bd2498bbd74ac2b42ac4ffd98f7c29e09f1a04e0..f237d80828c3d30dc734ceaeb6ee4351234d29a4 100644 (file)
--- a/drivers/gpu/drm/drm_mipi_dsi.c
+++ b/drivers/gpu/drm/drm_mipi_dsi.c
@@ -373,6 +373,7 @@ bool mipi_dsi_packet_format_is_short(u8 type)
        case MIPI_DSI_V_SYNC_END:
        case MIPI_DSI_H_SYNC_START:
        case MIPI_DSI_H_SYNC_END:
+       case MIPI_DSI_COMPRESSION_MODE:
        case MIPI_DSI_END_OF_TRANSMISSION:
        case MIPI_DSI_COLOR_MODE_OFF:
        case MIPI_DSI_COLOR_MODE_ON:
@@ -387,7 +388,6 @@ bool mipi_dsi_packet_format_is_short(u8 type)
        case MIPI_DSI_DCS_SHORT_WRITE:
        case MIPI_DSI_DCS_SHORT_WRITE_PARAM:
        case MIPI_DSI_DCS_READ:
-       case MIPI_DSI_DCS_COMPRESSION_MODE:
        case MIPI_DSI_SET_MAXIMUM_RETURN_PACKET_SIZE:
                return true;
        }
@@ -406,11 +406,11 @@ EXPORT_SYMBOL(mipi_dsi_packet_format_is_short);
 bool mipi_dsi_packet_format_is_long(u8 type)
 {
        switch (type) {
-       case MIPI_DSI_PPS_LONG_WRITE:
        case MIPI_DSI_NULL_PACKET:
        case MIPI_DSI_BLANKING_PACKET:
        case MIPI_DSI_GENERIC_LONG_WRITE:
        case MIPI_DSI_DCS_LONG_WRITE:
+       case MIPI_DSI_PICTURE_PARAMETER_SET:
        case MIPI_DSI_LOOSELY_PACKED_PIXEL_STREAM_YCBCR20:
        case MIPI_DSI_PACKED_PIXEL_STREAM_YCBCR24:
        case MIPI_DSI_PACKED_PIXEL_STREAM_YCBCR16:

diff --git a/include/video/mipi_display.h b/include/video/mipi_display.h
index cba57a678daf95401f8f9046364f86dece8bdcff..79fd71cf4934be3293164c70cc950ee103f5ad07 100644 (file)
--- a/include/video/mipi_display.h
+++ b/include/video/mipi_display.h
@@ -17,6 +17,9 @@ enum {
        MIPI_DSI_H_SYNC_START                           = 0x21,
        MIPI_DSI_H_SYNC_END                             = 0x31,
 
+       MIPI_DSI_COMPRESSION_MODE                       = 0x07,
+       MIPI_DSI_END_OF_TRANSMISSION                    = 0x08,
+
        MIPI_DSI_COLOR_MODE_OFF                         = 0x02,
        MIPI_DSI_COLOR_MODE_ON                          = 0x12,
        MIPI_DSI_SHUTDOWN_PERIPHERAL                    = 0x22,
@@ -35,18 +38,15 @@ enum {
 
        MIPI_DSI_DCS_READ                               = 0x06,
 
-       MIPI_DSI_DCS_COMPRESSION_MODE                   = 0x07,
-       MIPI_DSI_PPS_LONG_WRITE                         = 0x0A,
-
        MIPI_DSI_SET_MAXIMUM_RETURN_PACKET_SIZE         = 0x37,
 
-       MIPI_DSI_END_OF_TRANSMISSION                    = 0x08,
-
        MIPI_DSI_NULL_PACKET                            = 0x09,
        MIPI_DSI_BLANKING_PACKET                        = 0x19,
        MIPI_DSI_GENERIC_LONG_WRITE                     = 0x29,
        MIPI_DSI_DCS_LONG_WRITE                         = 0x39,
 
+       MIPI_DSI_PICTURE_PARAMETER_SET                  = 0x0a,
+
        MIPI_DSI_LOOSELY_PACKED_PIXEL_STREAM_YCBCR20    = 0x0c,
        MIPI_DSI_PACKED_PIXEL_STREAM_YCBCR24            = 0x1c,
        MIPI_DSI_PACKED_PIXEL_STREAM_YCBCR16            = 0x2c,