]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
iwlwifi: d3: disable dbg recording before entering D3
authorLuca Coelho <luciano.coelho@intel.com>
Wed, 7 Mar 2018 16:46:01 +0000 (18:46 +0200)
committerLuca Coelho <luciano.coelho@intel.com>
Thu, 2 Aug 2018 07:50:06 +0000 (10:50 +0300)
Currently the firmware does not stop recording debugging data when
entering D3 and this causes trouble (e.g. sporadic wake ups).

Fix that by stopping dbg recording when suspending.

Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
drivers/net/wireless/intel/iwlwifi/mvm/d3.c

index 3fcf489f3120f19db48f38d4eaf39baddd17ca70..79bdae994822844bcc07bb8b63b617f59982d042 100644 (file)
@@ -1037,6 +1037,13 @@ static int __iwl_mvm_suspend(struct ieee80211_hw *hw,
                        cpu_to_le32(IWL_WAKEUP_D3_CONFIG_FW_ERROR);
 #endif
 
+       /*
+        * TODO: this is needed because the firmware is not stopping
+        * the recording automatically before entering D3.  This can
+        * be removed once the FW starts doing that.
+        */
+       iwl_fw_dbg_stop_recording(&mvm->fwrt);
+
        /* must be last -- this switches firmware state */
        ret = iwl_mvm_send_cmd(mvm, &d3_cfg_cmd);
        if (ret)