]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
thunderbolt: Fix error code in tb_port_is_width_supported()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 3 Mar 2020 10:17:16 +0000 (13:17 +0300)
committerMika Westerberg <mika.westerberg@linux.intel.com>
Wed, 4 Mar 2020 09:34:17 +0000 (12:34 +0300)
This function is type bool, and it's supposed to return true on success.
Unfortunately, this path takes negative error codes and casts them to
bool (true) so it's treated as success instead of failure.

Fixes: 91c0c12080d0 ("thunderbolt: Add support for lane bonding")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
drivers/thunderbolt/switch.c

index 7d6ecc3425081cce72e79b475ac6a7f39cf53290..a2ce99051c51f8cd395e1893be12fc7e2ddce84a 100644 (file)
@@ -954,7 +954,7 @@ static bool tb_port_is_width_supported(struct tb_port *port, int width)
        ret = tb_port_read(port, &phy, TB_CFG_PORT,
                           port->cap_phy + LANE_ADP_CS_0, 1);
        if (ret)
-               return ret;
+               return false;
 
        widths = (phy & LANE_ADP_CS_0_SUPPORTED_WIDTH_MASK) >>
                LANE_ADP_CS_0_SUPPORTED_WIDTH_SHIFT;