]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
scsi: qla2xxx: Fix issue reported by static checker for qla2x00_els_dcmd2_sp_done()
authorQuinn Tran <quinn.tran@cavium.com>
Wed, 8 Aug 2018 03:39:52 +0000 (20:39 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 9 Aug 2018 01:38:26 +0000 (21:38 -0400)
This patch fixes following Smatch complaint:

drivers/scsi/qla2xxx/qla_iocb.c:2647 qla2x00_els_dcmd2_sp_done()
error: we previously assumed 'e' could be null (see line 2631)

Fixes: 8777e4314d39 ("scsi: qla2xxx: Migrate NVME N2N handling into state machine")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Quinn Tran <quinn.tran@cavium.com>
Signed-off-by: Himanshu Madhani <himanshu.madhani@cavium.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_iocb.c

index 059f2c9dc192b44d0e59f8023c8e8bb7545d1cf8..213321295753c5838f091df7bf0663997d5369ff 100644 (file)
@@ -2642,6 +2642,7 @@ qla2x00_els_dcmd2_sp_done(void *ptr, int res)
                                    elsio->u.els_plogi.els_resp_pyld,
                                    elsio->u.els_plogi.els_resp_pyld_dma);
                        sp->free(sp);
+                       return;
                }
                e->u.iosb.sp = sp;
                qla2x00_post_work(vha, e);