]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
regulator: axp20x: remove a redundant null check on rdev
authorColin Ian King <colin.king@canonical.com>
Fri, 15 Feb 2019 09:45:54 +0000 (09:45 +0000)
committerMark Brown <broonie@kernel.org>
Tue, 19 Feb 2019 15:27:56 +0000 (15:27 +0000)
Currently rdev is dereferenced when assigning desc before rdev is null
checked, this is leading to static analysis warnings.  However, rdev
can never be null, so the null check is redundant and can be removed.

Detected by CoverityScan, CID#1476031 ("Dereference before null check")

Fixes: 77e3e3b165db ("regulator: axp20x: add software based soft_start for AXP209 LDO3")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/axp20x-regulator.c

index 98efc28f65ed0b86270827e86ec3baae396cfcec..fba8f58ab7696a99e0080f9e808c4b0af684eebb 100644 (file)
@@ -372,9 +372,6 @@ static int axp20x_set_ramp_delay(struct regulator_dev *rdev, int ramp)
        const int *slew_rates;
        int rate_count = 0;
 
-       if (!rdev)
-               return -EINVAL;
-
        desc = rdev->desc;
 
        switch (axp20x->variant) {