]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
rtl8xxxu: Remove set but not used variable 'vif','dev','len'
authorzhengbin <zhengbin13@huawei.com>
Tue, 19 Nov 2019 02:25:14 +0000 (10:25 +0800)
committerKalle Valo <kvalo@codeaurora.org>
Wed, 20 Nov 2019 07:47:19 +0000 (09:47 +0200)
Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c: In function rtl8xxxu_c2hcmd_callback:
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:5396:24: warning: variable vif set but not used [-Wunused-but-set-variable]
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c: In function rtl8xxxu_c2hcmd_callback:
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:5397:17: warning: variable dev set but not used [-Wunused-but-set-variable]
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c: In function rtl8xxxu_c2hcmd_callback:
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:5400:6: warning: variable len set but not used [-Wunused-but-set-variable]

They are introduced by commit e542e66b7c2e ("rtl8xxxu:
add bluetooth co-existence support for single antenna"), but never used,
so remove them.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
Reviewed-by: Chris Chiu <chiu@endlessm.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c

index 1d94cab6f71ff7cde0f067a4fe5f1d29852a11c4..aa2bb2ae980965a670adfbdc8aca845910684bfa 100644 (file)
@@ -5393,18 +5393,13 @@ static void rtl8xxxu_c2hcmd_callback(struct work_struct *work)
 {
        struct rtl8xxxu_priv *priv;
        struct rtl8723bu_c2h *c2h;
-       struct ieee80211_vif *vif;
-       struct device *dev;
        struct sk_buff *skb = NULL;
        unsigned long flags;
-       int len;
        u8 bt_info = 0;
        struct rtl8xxxu_btcoex *btcoex;
 
        priv = container_of(work, struct rtl8xxxu_priv, c2hcmd_work);
-       vif = priv->vif;
        btcoex = &priv->bt_coex;
-       dev = &priv->udev->dev;
 
        if (priv->rf_paths > 1)
                goto out;
@@ -5415,7 +5410,6 @@ static void rtl8xxxu_c2hcmd_callback(struct work_struct *work)
                spin_unlock_irqrestore(&priv->c2hcmd_lock, flags);
 
                c2h = (struct rtl8723bu_c2h *)skb->data;
-               len = skb->len - 2;
 
                switch (c2h->id) {
                case C2H_8723B_BT_INFO: