gpio: davinci: Do not assume continuous IRQ numbering

Currently the driver assumes that the interrupts are continuous
and does platform_get_irq only once and assumes the rest are continuous,
instead call platform_get_irq for all the interrupts and store them
in an array for later use.

Signed-off-by: Keerthy <j-keerthy@ti.com>
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index 423d37c95e6b0c8f10f83875ac50e0f40eacf993..a5ece8ea79bc83837838760dd449e238e9570f3a 100644 (file)
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -55,7 +55,7 @@ static inline struct davinci_gpio_regs __iomem *irq2regs(struct irq_data *d)
        return g;
 }
 
-static int davinci_gpio_irq_setup(struct platform_device *pdev, int bank_irq);
+static int davinci_gpio_irq_setup(struct platform_device *pdev);
 
 /*--------------------------------------------------------------------------*/
 
@@ -167,8 +167,8 @@ davinci_gpio_get_pdata(struct platform_device *pdev)
 static int davinci_gpio_probe(struct platform_device *pdev)
 {
        static int ctrl_num, bank_base;
-       int gpio, bank, bank_irq, ret = 0;
-       unsigned ngpio, nbank;
+       int gpio, bank, i, ret = 0;
+       unsigned int ngpio, nbank, nirq;
        struct davinci_gpio_controller *chips;
        struct davinci_gpio_platform_data *pdata;
        struct device *dev = &pdev->dev;
@@ -197,6 +197,16 @@ static int davinci_gpio_probe(struct platform_device *pdev)
        if (WARN_ON(ARCH_NR_GPIOS < ngpio))
                ngpio = ARCH_NR_GPIOS;
 
+       /*
+        * If there are unbanked interrupts then the number of
+        * interrupts is equal to number of gpios else all are banked so
+        * number of interrupts is equal to number of banks(each with 16 gpios)
+        */
+       if (pdata->gpio_unbanked)
+               nirq = pdata->gpio_unbanked;
+       else
+               nirq = DIV_ROUND_UP(ngpio, 16);
+
        nbank = DIV_ROUND_UP(ngpio, 32);
        chips = devm_kcalloc(dev,
                             nbank, sizeof(struct davinci_gpio_controller),
@@ -209,10 +219,13 @@ static int davinci_gpio_probe(struct platform_device *pdev)
        if (IS_ERR(gpio_base))
                return PTR_ERR(gpio_base);
 
-       bank_irq = platform_get_irq(pdev, 0);
-       if (bank_irq < 0) {
-               dev_dbg(dev, "IRQ not populated\n");
-               return bank_irq;
+       for (i = 0; i < nirq; i++) {
+               chips->irqs[i] = platform_get_irq(pdev, i);
+               if (chips->irqs[i] < 0) {
+                       dev_info(dev, "IRQ not populated, err = %d\n",
+                                chips->irqs[i]);
+                       return chips->irqs[i];
+               }
        }
 
        snprintf(label, MAX_LABEL_SIZE, "davinci_gpio.%d", ctrl_num++);
@@ -249,7 +262,7 @@ static int davinci_gpio_probe(struct platform_device *pdev)
                goto err;
 
        platform_set_drvdata(pdev, chips);
-       ret = davinci_gpio_irq_setup(pdev, bank_irq);
+       ret = davinci_gpio_irq_setup(pdev);
        if (ret)
                goto err;
 
@@ -383,7 +396,7 @@ static int gpio_to_irq_unbanked(struct gpio_chip *chip, unsigned offset)
         * can provide direct-mapped IRQs to AINTC (up to 32 GPIOs).
         */
        if (offset < d->gpio_unbanked)
-               return d->base_irq + offset;
+               return d->irqs[offset];
        else
                return -ENODEV;
 }
@@ -392,11 +405,18 @@ static int gpio_irq_type_unbanked(struct irq_data *data, unsigned trigger)
 {
        struct davinci_gpio_controller *d;
        struct davinci_gpio_regs __iomem *g;
-       u32 mask;
+       u32 mask, i;
 
        d = (struct davinci_gpio_controller *)irq_data_get_irq_handler_data(data);
        g = (struct davinci_gpio_regs __iomem *)d->regs[0];
-       mask = __gpio_mask(data->irq - d->base_irq);
+       for (i = 0; i < MAX_INT_PER_BANK; i++)
+               if (data->irq == d->irqs[i])
+                       break;
+
+       if (i == MAX_INT_PER_BANK)
+               return -EINVAL;
+
+       mask = __gpio_mask(i);
 
        if (trigger & ~(IRQ_TYPE_EDGE_FALLING | IRQ_TYPE_EDGE_RISING))
                return -EINVAL;
@@ -458,7 +478,7 @@ static const struct of_device_id davinci_gpio_ids[];
  * (dm6446) can be set appropriately for GPIOV33 pins.
  */
 
-static int davinci_gpio_irq_setup(struct platform_device *pdev, int bank_irq)
+static int davinci_gpio_irq_setup(struct platform_device *pdev)
 {
        unsigned        gpio, bank;
        int             irq;
@@ -492,6 +512,7 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev, int bank_irq)
                dev_err(dev, "Error %ld getting gpio clock\n", PTR_ERR(clk));
                return PTR_ERR(clk);
        }
+
        ret = clk_prepare_enable(clk);
        if (ret)
                return ret;
@@ -531,12 +552,11 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev, int bank_irq)
        if (pdata->gpio_unbanked) {
                /* pass "bank 0" GPIO IRQs to AINTC */
                chips->chip.to_irq = gpio_to_irq_unbanked;
-               chips->base_irq = bank_irq;
                chips->gpio_unbanked = pdata->gpio_unbanked;
                binten = GENMASK(pdata->gpio_unbanked / 16, 0);
 
                /* AINTC handles mask/unmask; GPIO handles triggering */
-               irq = bank_irq;
+               irq = chips->irqs[0];
                irq_chip = gpio_get_irq_chip(irq);
                irq_chip->name = "GPIO-AINTC";
                irq_chip->irq_set_type = gpio_irq_type_unbanked;
@@ -547,10 +567,11 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev, int bank_irq)
                writel_relaxed(~0, &g->set_rising);
 
                /* set the direct IRQs up to use that irqchip */
-               for (gpio = 0; gpio < pdata->gpio_unbanked; gpio++, irq++) {
-                       irq_set_chip(irq, irq_chip);
-                       irq_set_handler_data(irq, chips);
-                       irq_set_status_flags(irq, IRQ_TYPE_EDGE_BOTH);
+               for (gpio = 0; gpio < pdata->gpio_unbanked; gpio++) {
+                       irq_set_chip(chips->irqs[gpio], irq_chip);
+                       irq_set_handler_data(chips->irqs[gpio], chips);
+                       irq_set_status_flags(chips->irqs[gpio],
+                                            IRQ_TYPE_EDGE_BOTH);
                }
 
                goto done;
@@ -560,7 +581,7 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev, int bank_irq)
         * Or, AINTC can handle IRQs for banks of 16 GPIO IRQs, which we
         * then chain through our own handler.
         */
-       for (gpio = 0, bank = 0; gpio < ngpio; bank++, bank_irq++, gpio += 16) {
+       for (gpio = 0, bank = 0; gpio < ngpio; bank++, gpio += 16) {
                /* disabled by default, enabled only as needed
                 * There are register sets for 32 GPIOs. 2 banks of 16
                 * GPIOs are covered by each set of registers hence divide by 2
@@ -587,8 +608,8 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev, int bank_irq)
                irqdata->bank_num = bank;
                irqdata->chip = chips;
 
-               irq_set_chained_handler_and_data(bank_irq, gpio_irq_handler,
-                                                irqdata);
+               irq_set_chained_handler_and_data(chips->irqs[bank],
+                                                gpio_irq_handler, irqdata);
 
                binten |= BIT(bank);
        }

diff --git a/include/linux/platform_data/gpio-davinci.h b/include/linux/platform_data/gpio-davinci.h
index 90ae19ca828f70927a13cb593aba39d52cf188cf..57a5a35e0073aedf560a53f7581996b21e652835 100644 (file)
--- a/include/linux/platform_data/gpio-davinci.h
+++ b/include/linux/platform_data/gpio-davinci.h
@@ -22,6 +22,7 @@
 #include <asm-generic/gpio.h>
 
 #define MAX_REGS_BANKS         5
+#define MAX_INT_PER_BANK 32
 
 struct davinci_gpio_platform_data {
        u32     ngpio;
@@ -41,7 +42,7 @@ struct davinci_gpio_controller {
        spinlock_t              lock;
        void __iomem            *regs[MAX_REGS_BANKS];
        int                     gpio_unbanked;
-       unsigned int            base_irq;
+       int                     irqs[MAX_INT_PER_BANK];
        unsigned int            base;
 };