]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
hrtimer: Add missing sparse annotation for __run_timer()
authorJules Irenge <jbi.octave@gmail.com>
Mon, 20 Jan 2020 22:43:47 +0000 (22:43 +0000)
committerThomas Gleixner <tglx@linutronix.de>
Wed, 22 Jan 2020 14:50:11 +0000 (15:50 +0100)
Sparse reports a warning at __run_hrtimer()
|warning: context imbalance in __run_hrtimer() - unexpected unlock

Add the missing must_hold() annotation.

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20200120224347.51843-1-jbi.octave@gmail.com
kernel/time/hrtimer.c

index d8b62f93fc8dcb6ad2b699c0ca8949ed25a1315b..3a609e7344f3d9106d93b6eb53e1138fcf48581d 100644 (file)
@@ -1477,7 +1477,7 @@ EXPORT_SYMBOL_GPL(hrtimer_active);
 static void __run_hrtimer(struct hrtimer_cpu_base *cpu_base,
                          struct hrtimer_clock_base *base,
                          struct hrtimer *timer, ktime_t *now,
-                         unsigned long flags)
+                         unsigned long flags) __must_hold(&cpu_base->lock)
 {
        enum hrtimer_restart (*fn)(struct hrtimer *);
        int restart;